fix: disable Details button until activity is available#759
Merged
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #673
This PR fixes the "Activity not found" error that appeared when tapping the Details button too quickly after sending a payment.
Description
When sending a payment, the success confetti sheet would show with the Details button enabled before the activity data was fully synced. Tapping Details prematurely would cause an error toast. This fix:
PaymentSuccessfulevent to confirm the activity is synced (already implemented)Preview
Screen_recording_20260130_131737.webm
QA Notes
1. Lightning send - Details button loading state
2. Onchain send - Details button loading state
3. Regression - Close button